Attention is currently required from: msuraev.
pespin has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-bsc/+/28892
)
Change subject: BSSMAP: make sure we don't try to reset non-existent entity
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
I was unable to reproduce the crashso I don't see
how we can fix this better - see related ticket.
bssmap_reset_resend_reset() is only
called by VTY cmd "DEFUN(msc_bssmap_reset, msc_bssmap_reset_cmd,", which I think
is clearly misuing the function by calling it without checking that the FSM is there. You
should check it in the VTY command and call vty_out to report that the reset was not
possible to the user.
--
To view, visit
https://gerrit.osmocom.org/c/osmo-bsc/+/28892
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: I235bdd42ea82e7b5a1a40f437ca34c49ad239c48
Gerrit-Change-Number: 28892
Gerrit-PatchSet: 1
Gerrit-Owner: msuraev <msuraev(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: msuraev <msuraev(a)sysmocom.de>
Gerrit-Comment-Date: Mon, 08 Aug 2022 08:46:14 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Comment-In-Reply-To: msuraev <msuraev(a)sysmocom.de>
Gerrit-MessageType: comment