Attention is currently required from: osmith.
neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/36892?usp=email )
Change subject: add umts_cell_id_test.c ......................................................................
Patch Set 4:
(1 comment)
File tests/umts_cell_id/umts_cell_id_test.c:
https://gerrit.osmocom.org/c/osmo-hnbgw/+/36892/comment/bccda4de_bbf3d44c PS4, Line 79: /* TODO? There is no bounds checking on RAC and SAC.
do you want to keep this?
yes, it is a different "problem" in the current umts_cell_id implementation. I noticed while writing the test that we have no bounds checking there, but that's for a separate patch, and possibly not even a problem...