Attention is currently required from: osmith.
neels has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-hnbgw/+/36892?usp=email )
Change subject: add umts_cell_id_test.c
......................................................................
Patch Set 4:
(1 comment)
File tests/umts_cell_id/umts_cell_id_test.c:
https://gerrit.osmocom.org/c/osmo-hnbgw/+/36892/comment/bccda4de_bbf3d44c
PS4, Line 79: /* TODO? There is no bounds checking on RAC and SAC.
do you want to keep this?
yes, it is a different
"problem" in the current umts_cell_id implementation. I noticed while writing
the test that we have no bounds checking there, but that's for a separate patch, and
possibly not even a problem...
--
To view, visit
https://gerrit.osmocom.org/c/osmo-hnbgw/+/36892?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-hnbgw
Gerrit-Branch: master
Gerrit-Change-Id: Ibbb61a2c53a11dea794f451d3074bc9ba50862fe
Gerrit-Change-Number: 36892
Gerrit-PatchSet: 4
Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: osmith <osmith(a)sysmocom.de>
Gerrit-Comment-Date: Thu, 06 Jun 2024 16:25:40 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: osmith <osmith(a)sysmocom.de>
Gerrit-MessageType: comment