Attention is currently required from: laforge.
daniel has posted comments on this change. (
https://gerrit.osmocom.org/c/libosmocore/+/34879?usp=email )
Change subject: Disable uring when building for embedded
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
why is it bad to run the pkg-config check
unconditionally? It will fail and not include the related […]
In
https://projects.osmocom.org/issues/6233 Hörnchen reported that it errors out even with
this patch.
At the time I think this was also the case with libpcsclite. If you don't have the
-dev package it will fail configure even with --enable-embedded, all our dev machines just
happen to have the "requirements" installed.
Reproduce by changing the requirements to something invalid in configure.ac, like
PKG_CHECK_MODULES(PCSC, libpcsclight) in line 200. I tried to put these checks after if
test x"$embedded", but this didn't change the behavior.
--
To view, visit
https://gerrit.osmocom.org/c/libosmocore/+/34879?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: Iec2503986c6d3487761ba592daef0fd42478aa7d
Gerrit-Change-Number: 34879
Gerrit-PatchSet: 1
Gerrit-Owner: daniel <dwillmann(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Comment-Date: Wed, 22 Nov 2023 17:10:53 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: laforge <laforge(a)osmocom.org>
Comment-In-Reply-To: daniel <dwillmann(a)sysmocom.de>
Gerrit-MessageType: comment