1 Feb
2023
1 Feb
'23
1:37 p.m.
Attention is currently required from: dexter.
fixeria has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-bsc/+/31126 )
Change subject: abis_rsl: add ericsson specific paging group IE to
rsl_ericsson_imm_assign_cmd
......................................................................
Patch Set 3:
(2 comments)
File src/osmo-bsc/abis_rsl.c:
https://gerrit.osmocom.org/c/osmo-bsc/+/31126/comment/a735171a_1789fc09
PS3, Line 974: msgb_put_u8(msg, RSL_IE_ERIC_PAGING_GROUP);
msgb_tv_put(msg, RSL_IE_ERIC_PAGING_GROUP, pag_grp)
File src/osmo-bsc/pcu_sock.c:
https://gerrit.osmocom.org/c/osmo-bsc/+/31126/comment/abdfab13_df8e3101
PS3, Line 484: extract_paging_group
I am a bit puzzled here. Why do we need *paging* group when sending Immediate Assignment
over AGCH? AGCH is used to assign Uplink TBFs on request from the MS, so the MS is
expecting to receive an Immediate Assignment on AGCH regardless on its paging group.
Paging group is needed when sending Immediate Assignment over PCH. In this case it's a
Downlink TBF assignment, which needs to be sent in the correct time (determined by paging
group), so that the MS does not miss it. This is already done above, see case
PCU_IF_SAPI_PCH.
I see you're saying in the commit message that it's required, but I am trying to
understand why it's required and how can it be used internally by the BTS.
Also, looks like PCU_IF_SAPI_AGCH_DT is defined but never used in osmo-pcu.git?
--
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/31126
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: I4452f4973d1ec69c96aad527b057226e8a6edf99
Gerrit-Change-Number: 31126
Gerrit-PatchSet: 3
Gerrit-Owner: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: dexter <pmaier(a)sysmocom.de>
Gerrit-Comment-Date: Wed, 01 Feb 2023 13:37:14 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment