[M] Change in osmo-ttcn3-hacks[master]: epdg: Add tests to validate concurrent connections

Attention is currently required from: laforge, lynxis lazus, osmith, pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36093?usp=email ) Change subject: epdg: Add tests to validate concurrent connections ...................................................................... Patch Set 2: (2 comments) File epdg/EPDG_Tests.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36093/comment/41a7efa1_c5f0… PS2, Line 797: -> sender vc_conn I am not sure if we understand each other. My suggestion was to use `from vc_conn_list[i]` (not `sender -> vc_conn_list[i]`), so that we make sure that each component in the list sends `COORD_CMD_READY`. You current logic would be satisfied even if the same component generates `num_ues` times `COORD_CMD_READY`. In other words, you just count messages but do not check where they're coming from. This repository contains a good amount of examples, and I would not say looking this up in the Quick Reference Card is a big deal. IMO, it's more likely to confuse the reader rather than educate them. In any case, this is not critical and you can keep it as you like. Just sharing my thoughts. https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36093/comment/5aeb0ca4_3dfb… PS2, Line 805: -> sender vc_conn Done -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36093?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I842dacda56abe47afb19e951eaae746b5e8d9fe7 Gerrit-Change-Number: 36093 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Wed, 28 Feb 2024 18:20:46 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: comment