Attention is currently required from: laforge, lynxis lazus, osmith, pespin.

View Change

2 comments:

• File epdg/EPDG_Tests.ttcn:

  • Patch Set #2, Line 797: -> sender vc_conn

    Definetly we don't want vc_conn_list[i] there, since in "sender X", X is an output param.

    I am not sure if we understand each other. My suggestion was to use `from vc_conn_list[i]` (not `sender -> vc_conn_list[i]`), so that we make sure that each component in the list sends `COORD_CMD_READY`. You current logic would be satisfied even if the same component generates `num_ues` times `COORD_CMD_READY`. In other words, you just count messages but do not check where they're coming from.

    I actually left the sender part on purpose so that it is easier for anybody adding new tests to figure out how to pass a message back to the specific vc_conn.

    This repository contains a good amount of examples, and I would not say looking this up in the Quick Reference Card is a big deal. IMO, it's more likely to confuse the reader rather than educate them.

    In any case, this is not critical and you can keep it as you like. Just sharing my thoughts.

  • Patch Set #2, Line 805: -> sender vc_conn

    Likewise here.

    Done

To view, visit change 36093. To unsubscribe, or for help writing mail filters, visit settings.