Attention is currently required from: laforge, lynxis lazus.
fixeria has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/39246?usp=email )
Change subject: gprs_gmm_util: add parsing of GMM Attach Requests ......................................................................
Patch Set 3:
(6 comments)
File src/sgsn/gprs_gmm_util.c:
https://gerrit.osmocom.org/c/osmo-sgsn/+/39246/comment/3c6f3fcc_79e725f4?usp... : PS3, Line 93: l3 pointers must point to gmm what does this even mean...
https://gerrit.osmocom.org/c/osmo-sgsn/+/39246/comment/c8ffa556_010c2e27?usp... : PS3, Line 94: rau_req (copy-paste) `rau_req` -> `att_req`
https://gerrit.osmocom.org/c/osmo-sgsn/+/39246/comment/7ae42587_171bda66?usp... : PS3, Line 97: struct msgb *msg `const`? you're not modifying it, right?
https://gerrit.osmocom.org/c/osmo-sgsn/+/39246/comment/d509c6e9_4b943961?usp... : PS3, Line 119: 21 where this magic number is coming from? do we have a define for it?
https://gerrit.osmocom.org/c/osmo-sgsn/+/39246/comment/06b2b8af_cee40bf8?usp... : PS3, Line 122: if (len == 0) "must be at least 2 bytes long" suggests `len < 2`?
https://gerrit.osmocom.org/c/osmo-sgsn/+/39246/comment/d1d36927_3c4f36c4?usp... : PS3, Line 143: 12 likewise