[L] Change in libosmo-sccp[master]: Implement M3UA-over-TCP (in addition to SCTP)

Attention is currently required from: fixeria, laforge. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/35796?usp=email ) Change subject: Implement M3UA-over-TCP (in addition to SCTP) ...................................................................... Patch Set 1: (7 comments) Patchset: PS1: I wonder whether we really want to add/maintain a "OSMO_SS7_ASP_PROT_M3UA_TCP" type, or whether both tcp and sctp should be "OSMO_SS7_ASP_PROT_M3UA" and maybe add a boolean/int ipproto in the asp object which really specified the detail about the transport protocol used beneath it. Otherwise you are mixing layers there for no good reason? File src/osmo_ss7_asp.c: https://gerrit.osmocom.org/c/libosmo-sccp/+/35796/comment/4caed6c8_590b0afa PS1, Line 853: ss7_asp_m3ua_tcp_srv_conn_cb You can move most of it to a m3ua_tcp_asp_read_cb(struct osmo_ss7_asp *asp) and use asp->is_server to do the different stuff in the same function. File src/osmo_ss7_vty.c: https://gerrit.osmocom.org/c/libosmo-sccp/+/35796/comment/cbab4302_314af15e PS1, Line 62: "MTP3 User Adaptation (SCTP)\n" \ As mentioned in earlier patches, you can remove the "SCTP" stuff. "Maybe use for the other one: MTP3 User Adaptation (over TCP)". https://gerrit.osmocom.org/c/libosmo-sccp/+/35796/comment/59043139_afe10b9a PS1, Line 1994: "Display all M3UA (SCTP and TCP) ASs\n" drop "SCTP and TCP". https://gerrit.osmocom.org/c/libosmo-sccp/+/35796/comment/7eceb507_20b5cfa1 PS1, Line 2013: if (filter && !strcmp(filter, "m3ua")) { sounds like this can be moved into a "bool only_m3ua" out of the loop. Will make te code clear and avoid calling it each time. File src/osmo_ss7_xua_srv.c: https://gerrit.osmocom.org/c/libosmo-sccp/+/35796/comment/7f86f4b7_f1117cb5 PS1, Line 168: if (ss7_asp_proto_to_ip_proto(asp->cfg.proto) == IPPROTO_SCTP) { you wanna name this probably "ss7_asp_proto_to_ipproto" (see "ipproto" instead of "ip_proto") File src/xua_rkm.c: https://gerrit.osmocom.org/c/libosmo-sccp/+/35796/comment/c1765494_a08fe3fe PS1, Line 240: M3UA-over-SCTP or M3UA-over-TCP? Can we use asp->cfg.proto maybe? I'd keep the usual one to mean sctp, and probably add something else for tcp. -- To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/35796?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-sccp Gerrit-Branch: master Gerrit-Change-Id: I8c76d271472befacbeb998a93bbdc9e8660d9b5d Gerrit-Change-Number: 35796 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Sat, 03 Feb 2024 01:36:37 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: comment