Attention is currently required from: fixeria, laforge.
7 comments:
Patchset:
I wonder whether we really want to add/maintain a "OSMO_SS7_ASP_PROT_M3UA_TCP" type, or whether both tcp and sctp should be "OSMO_SS7_ASP_PROT_M3UA" and maybe add a boolean/int ipproto in the asp object which really specified the detail about the transport protocol used beneath it.
Otherwise you are mixing layers there for no good reason?
File src/osmo_ss7_asp.c:
Patch Set #1, Line 853: ss7_asp_m3ua_tcp_srv_conn_cb
This function is 90% identical to `m3ua_tcp_cli_read_cb()`. […]
You can move most of it to a m3ua_tcp_asp_read_cb(struct osmo_ss7_asp *asp) and use asp->is_server to do the different stuff in the same function.
File src/osmo_ss7_vty.c:
Patch Set #1, Line 62: "MTP3 User Adaptation (SCTP)\n" \
As mentioned in earlier patches, you can remove the "SCTP" stuff.
"Maybe use for the other one: MTP3 User Adaptation (over TCP)".
Patch Set #1, Line 1994: "Display all M3UA (SCTP and TCP) ASs\n"
drop "SCTP and TCP".
Patch Set #1, Line 2013: if (filter && !strcmp(filter, "m3ua")) {
sounds like this can be moved into a "bool only_m3ua" out of the loop. Will make te code clear and avoid calling it each time.
File src/osmo_ss7_xua_srv.c:
Patch Set #1, Line 168: if (ss7_asp_proto_to_ip_proto(asp->cfg.proto) == IPPROTO_SCTP) {
you wanna name this probably "ss7_asp_proto_to_ipproto" (see "ipproto" instead of "ip_proto")
File src/xua_rkm.c:
Patch Set #1, Line 240: M3UA-over-SCTP or M3UA-over-TCP? Can we use asp->cfg.proto maybe?
@laforge@osmocom.org your feedback would be welcome here.
I'd keep the usual one to mean sctp, and probably add something else for tcp.
To view, visit change 35796. To unsubscribe, or for help writing mail filters, visit settings.