Attention is currently required from: fixeria, neels.
laforge has posted comments on this change. (
https://gerrit.osmocom.org/c/libosmocore/+/35312?usp=email )
Change subject: utils: fix OSMO_STRBUF_REMAIN to handle sb.pos == NULL correctly
......................................................................
Patch Set 1:
(1 comment)
File include/osmocom/core/utils.h:
https://gerrit.osmocom.org/c/libosmocore/+/35312/comment/19efe077_6f56b6c6
PS1, Line 284: /*! Get remaining space for characters and terminating nul in the given
struct osmo_strbuf.
i'm not sure about the inlining, I think i'd
just submit a normal function in utils.c. […]
I'd expect the linker will throw
out any unused functions anyway. So I don't seee any problem/overhead at runtime.
Optimization for compile speed is not a goal.
--
To view, visit
https://gerrit.osmocom.org/c/libosmocore/+/35312?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I294a74a99c40995cf7fb5520d61f697d967be5a4
Gerrit-Change-Number: 35312
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-CC: laforge <laforge(a)osmocom.org>
Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Sun, 17 Dec 2023 10:41:39 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: neels <nhofmeyr(a)sysmocom.de>
Gerrit-MessageType: comment