8 Mar
2023
8 Mar
'23
8:39 p.m.
Attention is currently required from: osmith, laforge, fixeria, pespin.
msuraev has posted comments on this change. (
https://gerrit.osmocom.org/c/libosmocore/+/31513 )
Change subject: GSMTAP: allow configuring src IP for log messages
......................................................................
Patch Set 11:
(4 comments)
File include/osmocom/core/logging.h:
https://gerrit.osmocom.org/c/libosmocore/+/31513/comment/b45b002a_72fc7f37
PS11, Line 414: log_set_src_ip
This is the GSMTAP target specific API, so I believe
it should be reflected in the symbol name, e.g. […]
Done
File src/core/logging_gsmtap.c:
https://gerrit.osmocom.org/c/libosmocore/+/31513/comment/c6d98feb_03ee44b6
PS11, Line 127: ip
I think it can be a hostname, not necessarily an IP
address? […]
That would make configuration ambiguous since hostname can be
associated with multiple IP. I don't see a point in encouraging this.
https://gerrit.osmocom.org/c/libosmocore/+/31513/comment/895cbb29_cedb8210
PS11, Line 135: gsmtap_source_init2
Looking at the code I can see `gsmtap_source_init2()`
can handle `src == NULL`, so why not calling i […]
Done
https://gerrit.osmocom.org/c/libosmocore/+/31513/comment/04878123_9e2064a0
PS11, Line 145: target->tgt_gsmtap.src_addr
What if `src_addr` was set before? You will be leaking
memory here. […]
Done
--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/31513
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I9000269ce5b3dce1e757271b7c42e77b68d38f25
Gerrit-Change-Number: 31513
Gerrit-PatchSet: 11
Gerrit-Owner: msuraev <msuraev(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-CC: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Attention: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Wed, 08 Mar 2023 19:39:26 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-MessageType: comment