Attention is currently required from: osmith, laforge, fixeria, pespin.
4 comments:
File include/osmocom/core/logging.h:
Patch Set #11, Line 414: log_set_src_ip
This is the GSMTAP target specific API, so I believe it should be reflected in the symbol name, e.g. […]
Done
File src/core/logging_gsmtap.c:
I think it can be a hostname, not necessarily an IP address? […]
That would make configuration ambiguous since hostname can be associated with multiple IP. I don't see a point in encouraging this.
Patch Set #11, Line 135: gsmtap_source_init2
Looking at the code I can see `gsmtap_source_init2()` can handle `src == NULL`, so why not calling i […]
Done
Patch Set #11, Line 145: target->tgt_gsmtap.src_addr
What if `src_addr` was set before? You will be leaking memory here. […]
Done
To view, visit change 31513. To unsubscribe, or for help writing mail filters, visit settings.