Attention is currently required from: osmith, laforge, fixeria.
dexter has posted comments on this change. (
https://gerrit.osmocom.org/c/pysim/+/32532 )
Change subject: pySim-shell: fix compatibility problem with cmd2 >= 2.0.0 (Settable)
......................................................................
Patch Set 16:
(2 comments)
File pySim-shell.py:
https://gerrit.osmocom.org/c/pysim/+/32532/comment/f10bfcf6_b0a664ef
PS14, Line 26: packaging
You're using this package, but not adding it as a
dependency to `requirements.txt` and `setup.py`. […]
Done
https://gerrit.osmocom.org/c/pysim/+/32532/comment/a119a6fa_cb74861e
PS14, Line 154: \
You don't really need to put these `\`, but not
critical.
(hopefully pylint does not need them.)
--
To view, visit
https://gerrit.osmocom.org/c/pysim/+/32532
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: I38efe4702277ee092a5542d7d659df08cb0adeff
Gerrit-Change-Number: 32532
Gerrit-PatchSet: 16
Gerrit-Owner: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-CC: laforge <laforge(a)osmocom.org>
Gerrit-CC: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Mon, 15 May 2023 14:30:07 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-MessageType: comment