Attention is currently required from: osmith, laforge, fixeria.
View Change
2 comments:
File pySim-shell.py:
Patch Set #14, Line 26: packaging
You're using this package, but not adding it as a dependency to `requirements.txt` and `setup.py`. […]
Done
Patch Set #14, Line 154: \
You don't really need to put these `\`, but not critical.
(hopefully pylint does not need them.)
To view, visit change 32532. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: I38efe4702277ee092a5542d7d659df08cb0adeff
Gerrit-Change-Number: 32532
Gerrit-PatchSet: 16
Gerrit-Owner: dexter <pmaier@sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy@sysmocom.de>
Gerrit-CC: laforge <laforge@osmocom.org>
Gerrit-CC: osmith <osmith@sysmocom.de>
Gerrit-Attention: osmith <osmith@sysmocom.de>
Gerrit-Attention: laforge <laforge@osmocom.org>
Gerrit-Attention: fixeria <vyanitskiy@sysmocom.de>
Gerrit-Comment-Date: Mon, 15 May 2023 14:30:07 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: fixeria <vyanitskiy@sysmocom.de>
Gerrit-MessageType: comment