Attention is currently required from: pespin.
Jenkins Builder has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/31214 )
Change subject: mgcp_sdp: add fmtp string to define HR GSM RTP format ......................................................................
Patch Set 8:
(4 comments)
File src/libosmo-mgcp/mgcp_network.c:
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-3939): https://gerrit.osmocom.org/c/osmo-mgw/+/31214/comment/0998c34f_8b846931 PS8, Line 704: switch(msgb_length(msg)) that open brace { should be on the previous line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-3939): https://gerrit.osmocom.org/c/osmo-mgw/+/31214/comment/c7a9422e_f7840204 PS8, Line 704: switch(msgb_length(msg)) space required before the open parenthesis '('
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-3939): https://gerrit.osmocom.org/c/osmo-mgw/+/31214/comment/7c50bff0_194f2439 PS8, Line 706: case GSM_HR_BYTES + sizeof(struct rtp_hdr): code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-3939): https://gerrit.osmocom.org/c/osmo-mgw/+/31214/comment/ea795429_3d577d89 PS8, Line 706: case GSM_HR_BYTES + sizeof(struct rtp_hdr): please, no spaces at the start of a line