Change in pysim[master]: filesystem: Introduce the basic notion of 'logical channels'

Attention is currently required from: laforge. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/28628 ) Change subject: filesystem: Introduce the basic notion of 'logical channels' ...................................................................... Patch Set 3: (1 comment) File pySim/filesystem.py: https://gerrit.osmocom.org/c/pysim/+/28628/comment/ff501191_084d3ee8 PS1, Line 55: if cla >> 4 in [0x0, 0xA, 0x8]: What if neither (cla >> 4) is in [0x0, 0xA, 0x8], nor (cla & 0xD0) is in [0x40, 0xC0]? I would raise a ValueError, just to be sure the function would not return None. -- To view, visit https://gerrit.osmocom.org/c/pysim/+/28628 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I7aa994b625467d4e46a2edd8123240b930305360 Gerrit-Change-Number: 28628 Gerrit-PatchSet: 3 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Sun, 17 Jul 2022 13:17:16 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment