Attention is currently required from: osmith, pespin.
neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/35097?usp=email )
Change subject: vty: disallow combination of early-IA and frequency hopping ......................................................................
Patch Set 4:
(2 comments)
File src/osmo-bsc/bts_vty.c:
https://gerrit.osmocom.org/c/osmo-bsc/+/35097/comment/4899a31c_83a5bb8e PS3, Line 3231: bts->imm_ass_time = IMM_ASS_TIME_POST_CHAN_ACK;
same
Done
File src/osmo-bsc/bts_vty.c:
https://gerrit.osmocom.org/c/osmo-bsc/+/35097/comment/8881326a_ef45b916 PS4, Line 3245: : ts->fi->id rationale: the choice is: a) use fi->id directly. b) osmo_fsm_inst_name() includes the FSM instance pointer address, which makes the vty output untestable. VTY tests are run against the osmo-bsc binary, so where to call osmo_fsm_log_addr(false)? add a new DEFUN to logging_vty.c, wait for it to merge to libosmocore, then call that here in the vty test? Then find out that calling from vty is too late, because osmo_fsm_inst->name for the timeslots was composed before the test could run the vty command? modify the doc/examples/osmo-bsc/osmo-bsc-minimal.cfg to include that new vty cmd early enough, hopefully; but is the file then still "minimal"? so instead add another .cfg file copy specifically for the vty tests.