[S] Change in osmo-bts[master]: rsl_rx_ipac_XXcx: parse csd_fmt_d/ir

Attention is currently required from: osmith. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/31795 ) Change subject: rsl_rx_ipac_XXcx: parse csd_fmt_d/ir ...................................................................... Patch Set 1: (1 comment) File src/common/rsl.c: https://gerrit.osmocom.org/c/osmo-bts/+/31795/comment/639e52ba_2f9da67a PS1, Line 2772: csd_fmt_d = *csd_fmt & 0xf; Are you sure this is correct? In the previous patch I see: ``` |=== | Offset | Size | Description | 0 | 4 | RTP CSD Format IR | 4 | 4 | RTP CSD Format D |=== ``` so if this table is correct, it should be (assuming MSB): ``` csd_fmt_ir = *csd_fmt & 0x0f; csd_fmt_d = *csd_fmt >> 4; ``` or vice versa if the bit order is LSB. -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/31795 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Ibfc7811387df5224682d7e6a313d38648d3d8c48 Gerrit-Change-Number: 31795 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Thu, 09 Mar 2023 13:25:47 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment