Attention is currently required from: osmith.
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/31795 )
Change subject: rsl_rx_ipac_XXcx: parse csd_fmt_d/ir ......................................................................
Patch Set 1:
(1 comment)
File src/common/rsl.c:
https://gerrit.osmocom.org/c/osmo-bts/+/31795/comment/639e52ba_2f9da67a PS1, Line 2772: csd_fmt_d = *csd_fmt & 0xf; Are you sure this is correct? In the previous patch I see:
``` |=== | Offset | Size | Description | 0 | 4 | RTP CSD Format IR | 4 | 4 | RTP CSD Format D |=== ```
so if this table is correct, it should be (assuming MSB):
``` csd_fmt_ir = *csd_fmt & 0x0f; csd_fmt_d = *csd_fmt >> 4; ```
or vice versa if the bit order is LSB.