Attention is currently required from: osmith.

View Change

1 comment:

• File src/common/rsl.c:

  • Patch Set #1, Line 2772: csd_fmt_d = *csd_fmt & 0xf;

    Are you sure this is correct? In the previous patch I see:

    ```
    |===
    | Offset | Size | Description
    | 0 | 4 | RTP CSD Format IR
    | 4 | 4 | RTP CSD Format D
    |===
    ```

    so if this table is correct, it should be (assuming MSB):

    ```
    csd_fmt_ir = *csd_fmt & 0x0f;
    csd_fmt_d = *csd_fmt >> 4;
    ```

    or vice versa if the bit order is LSB.

To view, visit change 31795. To unsubscribe, or for help writing mail filters, visit settings.