Attention is currently required from: daniel.
laforge has posted comments on this change. (
https://gerrit.osmocom.org/c/libosmocore/+/30936 )
Change subject: gpsr_ns2_udp: Use osmo_io_fd instead of osmo_fd
......................................................................
Patch Set 3:
(2 comments)
File src/gb/gprs_ns2_udp.c:
https://gerrit.osmocom.org/c/libosmocore/+/30936/comment/85f27c3d_58e01baf
PS3, Line 50: struct
might be worth renaming the struct member from fd to iofd or io_fd to make the code more
obvious
https://gerrit.osmocom.org/c/libosmocore/+/30936/comment/c5ab51fc_967ec21c
PS3, Line 153: rc =
you can do away with the rc variable as there are no local users here anymore. just return
osmo_iofd_sendto_msgb()?
--
To view, visit
https://gerrit.osmocom.org/c/libosmocore/+/30936
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: Id776d2d9f35c304620f3d5b94492148dd987f5a0
Gerrit-Change-Number: 30936
Gerrit-PatchSet: 3
Gerrit-Owner: daniel <dwillmann(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: laforge <laforge(a)osmocom.org>
Gerrit-Attention: daniel <dwillmann(a)sysmocom.de>
Gerrit-Comment-Date: Tue, 17 Jan 2023 11:29:28 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment