Attention is currently required from: neels.
pespin has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-mgw/+/29861
)
Change subject: Rename and move func checking if amr mode is explicitly configured
......................................................................
Patch Set 1:
(1 comment)
File include/osmocom/mgcp/mgcp_codec.h:
https://gerrit.osmocom.org/c/osmo-mgw/+/29861/comment/079a12dd_0d78fae0
PS1, Line 20: bool mgcp_codec_amr_mode_is_indicated(const struct mgcp_rtp_codec *codec);
problems: […]
First dot: I'll rename it to
mgcp_codec_amr_mode_is_indicated().
Second dot: Changing he non-compliant code logic has a lot of implications like breaking
compatibility with older clients. This needs to be done carefully and it's something
out of the scope of this patchset. I'm just cleaning current code maintaining logic
here.
Third dot: I initially thought about using this function in osmux.c but finally it seems I
didn't. I'll leave it static.
--
To view, visit
https://gerrit.osmocom.org/c/osmo-mgw/+/29861
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-mgw
Gerrit-Branch: master
Gerrit-Change-Id: I8dce3038ebccf5e1e37e2908070a67d66693a96f
Gerrit-Change-Number: 29861
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Comment-Date: Tue, 25 Oct 2022 11:16:39 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: neels <nhofmeyr(a)sysmocom.de>
Gerrit-MessageType: comment