Attention is currently required from: neels.

View Change

1 comment:

• File include/osmocom/mgcp/mgcp_codec.h:

  • Patch Set #1, Line 20: bool mgcp_codec_amr_mode_is_indicated(const struct mgcp_rtp_codec *codec);

    problems: […]

    First dot: I'll rename it to mgcp_codec_amr_mode_is_indicated().

    Second dot: Changing he non-compliant code logic has a lot of implications like breaking compatibility with older clients. This needs to be done carefully and it's something out of the scope of this patchset. I'm just cleaning current code maintaining logic here.

    Third dot: I initially thought about using this function in osmux.c but finally it seems I didn't. I'll leave it static.

To view, visit change 29861. To unsubscribe, or for help writing mail filters, visit settings.