pespin has submitted this change. ( https://gerrit.osmocom.org/c/libosmo-abis/+/28070 )
Change subject: input/ipaccess: Remove unneeded osmo_fd_write_enable() ......................................................................
input/ipaccess: Remove unneeded osmo_fd_write_enable()
Recent commit optimize the same function by avoiding an extra poll loop when e1i_ts->sign.delay was zero. Upon doing so, the osmo_fd_write_disable() was moved to some conditional paths. Hence, the WRITE flag is left set and we don't need to set it again in the code path modified in this commit.
Fixes: 28fea7746bbc2fb8ca0f677a93559c0c9f4cff09 Change-Id: I84787b6de2a5ccc82bd8f19ce874e73708bc287f --- M src/input/ipaccess.c 1 file changed, 1 insertion(+), 1 deletion(-)
Approvals: Jenkins Builder: Verified osmith: Looks good to me, but someone else must approve fixeria: Looks good to me, but someone else must approve pespin: Looks good to me, approved
diff --git a/src/input/ipaccess.c b/src/input/ipaccess.c index b995fde..ca48d21 100644 --- a/src/input/ipaccess.c +++ b/src/input/ipaccess.c @@ -509,7 +509,7 @@ case E1INP_SIGN_OSMO: break; default: - osmo_fd_write_enable(bfd); /* come back for more msg */ + /* leave WRITE flag enabled, come back for more msg */ ret = -EINVAL; goto out; }