Attention is currently required from: pespin.
fixeria has posted comments on this change. (
https://gerrit.osmocom.org/c/osmocom-bb/+/35579?usp=email )
Change subject: mobile: init/deinit GAPK I/O based on CC transaction events
......................................................................
Patch Set 4:
(1 comment)
File src/host/layer23/include/osmocom/bb/mobile/tch.h:
https://gerrit.osmocom.org/c/osmocom-bb/+/35579/comment/7a9c7e62_c2b3dcb9
PS3, Line 8: bool voice_or_data; /* voice (true) or data (false) */
it is totally misleading because when reading code
"if (voice_or_data)" it clearly seems to (wrongly […]
Done.
--
To view, visit
https://gerrit.osmocom.org/c/osmocom-bb/+/35579?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-Change-Id: I28f87f6a6de673611aa02a24e8985aee23d4498b
Gerrit-Change-Number: 35579
Gerrit-PatchSet: 4
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Wed, 17 Jan 2024 21:52:31 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-MessageType: comment