Attention is currently required from: csaba.sipos.
pespin has posted comments on this change by csaba.sipos. ( https://gerrit.osmocom.org/c/osmo-bsc/+/39315?usp=email )
Change subject: nokia_site: add reset_type attribute ......................................................................
Patch Set 3:
(3 comments)
File src/osmo-bsc/bts_nokia_site.c:
https://gerrit.osmocom.org/c/osmo-bsc/+/39315/comment/690f594c_c3afe783?usp=... : PS3, Line 604: { 2, "reserved" }, Maybe start it with a cap letter too? Or is this specified as so somewhere?
https://gerrit.osmocom.org/c/osmo-bsc/+/39315/comment/8ab8ef1b_81f40af9?usp=... : PS3, Line 1716: if (find_element(noh->data, len_data, NOKIA_EI_RESET_TYPE, &reset_type, afaiu this IE is unrelated to the EI_BTS_TYPE above, so it probably makes much more sense to pul lal lthis new code outside the if block?
https://gerrit.osmocom.org/c/osmo-bsc/+/39315/comment/b70265eb_87b7a709?usp=... : PS3, Line 1718: LOG_BTS(bts, DNM, LOGL_INFO, "Rx BTS reset type = %s\n", You probably want to do '%s' (with simple quotes) since the strings have spaces, to easiely understand the resulting string.