17 Jan
2023
17 Jan
'23
2:25 p.m.
Attention is currently required from: pespin. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/30996 )
Change subject: layer23: Initial integration of tun device ......................................................................
Patch Set 3: Code-Review+1
(2 comments)
File src/host/layer23/src/common/apn.c:
https://gerrit.osmocom.org/c/osmocom-bb/+/30996/comment/eb42a6cc_acf262cb PS3, Line 88: /* TODO: prepare & transmit SNDCP UNITDATA.req */ unresolved TODO on purpose?
https://gerrit.osmocom.org/c/osmocom-bb/+/30996/comment/c5c41d2a_dd72c6da PS3, Line 94: what use "flags" instead of "what" here, so it's more descriptive? I realize that it's also "what" in libosmocore, but still
--
To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/30996
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-Change-Id: I86cac406843157aa2e51727cf8ccac9804d7961d
Gerrit-Change-Number: 30996
Gerrit-PatchSet: 3
Gerrit-Owner: pespin pespin@sysmocom.de
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: osmith osmith@sysmocom.de
Gerrit-Attention: pespin pespin@sysmocom.de
Gerrit-Comment-Date: Tue, 17 Jan 2023 13:25:26 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment