pespin has posted comments on this change. (
https://gerrit.osmocom.org/c/libosmocore/+/34113 )
Change subject: socket: Add osmo_sock_init flag to enable SCTP ASCONF features
......................................................................
Patch Set 3:
(2 comments)
File src/core/socket.c:
https://gerrit.osmocom.org/c/libosmocore/+/34113/comment/e6a07b51_37f3a252
PS2, Line 709: skip
agreed that "skipping" looks better
Done
https://gerrit.osmocom.org/c/libosmocore/+/34113/comment/f6cdccc4_cbd7bb19
PS2, Line 724: LOGP(DLGLOBAL, LOGL_NOTICE, "Built without support for
setsockopt(SCTP_ASCONF_SUPPORTED), skip!\n");
skipping ?
Done
--
To view, visit
https://gerrit.osmocom.org/c/libosmocore/+/34113
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: Iac07031927b66a9d32d2bb2faab817e4c922a359
Gerrit-Change-Number: 34113
Gerrit-PatchSet: 3
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Mon, 21 Aug 2023 08:33:20 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: osmith <osmith(a)sysmocom.de>
Comment-In-Reply-To: laforge <laforge(a)osmocom.org>
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: comment