14 Oct
2022
14 Oct
'22
2:24 p.m.
Attention is currently required from: pespin. msuraev has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/29752 )
Change subject: SNDCP: add LLE-specific logging wrapper ......................................................................
Patch Set 4:
(1 comment)
File src/sgsn/gprs_sndcp.c:
https://gerrit.osmocom.org/c/osmo-sgsn/+/29752/comment/b42e17cc_9c86cc25 PS4, Line 225: (LLE)->llme->tlli, (LLE)->sapi, (NSAPI), llist_count(&gprs_sndcp_entities), ##ARGS)
Counting a list every time we log something sounds a bit crazy... […]
Counting list only when we need to log some error (which is most of the cases in the patch) is way better than maintaining separate counter all the time.
--
To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/29752
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-sgsn
Gerrit-Branch: master
Gerrit-Change-Id: Idfab1f4be034fc8eab8f87bd8cd88723939e107e
Gerrit-Change-Number: 29752
Gerrit-PatchSet: 4
Gerrit-Owner: msuraev msuraev@sysmocom.de
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin pespin@sysmocom.de
Gerrit-Attention: pespin pespin@sysmocom.de
Gerrit-Comment-Date: Fri, 14 Oct 2022 12:24:22 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin pespin@sysmocom.de
Gerrit-MessageType: comment