Attention is currently required from: jolly.
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/34889?usp=email )
Change subject: ASCI: Control uplink access bursts detection of physical interface ......................................................................
Patch Set 1: Code-Review+1
(1 comment)
File src/common/l1sap.c:
https://gerrit.osmocom.org/c/osmo-bts/+/34889/comment/49c79392_286d801c PS1, Line 2448: struct gsm_bts_trx *trx can we accept `struct gsm_lchan *lchan` directly here? ... and this avoid having to do `gsm_lchan2chan_nr(lchan)` and then `get_lchan_by_chan_nr()` again. Yes, we would still need to do `gsm_lchan2chan_nr(lchan)` here, but this way we avoid unneeded lchan lookups.