Attention is currently required from: neels, fixeria.
pespin has posted comments on this change. (
https://gerrit.osmocom.org/c/osmocom-bb/+/30950 )
Change subject: layer23: Add initial VTY support for l23_apps
......................................................................
Patch Set 5:
(1 comment)
File src/host/layer23/src/common/main.c:
https://gerrit.osmocom.org/c/osmocom-bb/+/30950/comment/50e71214_61ff4e0b
PS5, Line 177: config_file = optarg;
this is also removing two cmdline options, is that
intended? it is not mentioned in the commit log, […]
Yes it's intended because
anyway they were not used and didn't make any sense at all. In here I'm just doing
similar to what we do in all osmocom apps: Simply pass a cfg file and it should contain
info on which IP address and port to use.
--
To view, visit
https://gerrit.osmocom.org/c/osmocom-bb/+/30950
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-Change-Id: Ife3a3373e5a9c0c8e5959ac714e140e72d6c363a
Gerrit-Change-Number: 30950
Gerrit-PatchSet: 5
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-CC: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Mon, 16 Jan 2023 09:16:00 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: neels <nhofmeyr(a)sysmocom.de>
Gerrit-MessageType: comment