17 Mar
2024
17 Mar
'24
6:33 p.m.
Attention is currently required from: laforge, osmith, pespin.
fixeria has posted comments on this change. (
https://gerrit.osmocom.org/c/mncc-python/+/36318?usp=email )
Change subject: Initial port from python2 to python3
......................................................................
Patch Set 4: Code-Review+1
(1 comment)
File mncc_test.py:
https://gerrit.osmocom.org/c/mncc-python/+/36318/comment/58eea7be_508dd113
PS4, Line 73: nr /= 2
Oh, btw, I didn't notice this earlier, but doing `/=` would convert `nr` from `int` to
`float`, what would then result into a `TypeError` exception.
```
>> nr = 8
>> nr /= 2
>> nr
4.0
>> range(nr)
Traceback (most recent call
last):
File "<stdin>", line 1, in <module>
TypeError: 'float' object cannot be interpreted as an integer
```
In py2, you would get either `int` or `float`, but in py3 you always get `float`. Use
`//=` instead.
--
To view, visit https://gerrit.osmocom.org/c/mncc-python/+/36318?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: mncc-python
Gerrit-Branch: master
Gerrit-Change-Id: Ie6ecd37353b35a6ac13c6578585c714c9ab46e06
Gerrit-Change-Number: 36318
Gerrit-PatchSet: 4
Gerrit-Owner: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Sun, 17 Mar 2024 18:33:02 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment