Attention is currently required from: laforge.
Hoernchen has posted comments on this change by Hoernchen. (
https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/39447?usp=email )
Change subject: add ext power detect & dev reset
......................................................................
Patch Set 10:
(1 comment)
File sysmoOCTSIM/main.c:
https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/39447/comment/9fcf88ee_49…
:
PS7, Line 334: {
not everyone ever lookin at that code in the future is
as smart as you and knows that a change from […]
It does not need to be changed in
the descriptor, because the device always has to advertise its max power consumption
anyway, no matter where that power is coming from, I just thought it would be nice to just
add that. The only consumer of that information is probably lsusb -vvv (so me, while
giving it a try) because we don't attach the octsim to smartphones or other devices
that can't handle the power draw without ext power.... It does not need a usb reset
either, but the firmware does, just to be safe. This happens anway with the current
hardware when messing with the plug, I just wanted it to be consistent.
--
To view, visit
https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/39447?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-ccid-firmware
Gerrit-Branch: master
Gerrit-Change-Id: Ied62450670dba2227daa96cbcd162cfe8414445a
Gerrit-Change-Number: 39447
Gerrit-PatchSet: 10
Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Comment-Date: Wed, 12 Mar 2025 10:03:55 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Hoernchen <ewild(a)sysmocom.de>
Comment-In-Reply-To: laforge <laforge(a)osmocom.org>