Attention is currently required from: neels. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/29364 )
Change subject: oml: Delay Tx of OPSTART(BBTRANSC) after rx of RSL CONNECT ACK ......................................................................
Patch Set 1: Code-Review+2
(2 comments)
File src/osmo-bsc/bts_ipaccess_nanobts.c:
https://gerrit.osmocom.org/c/osmo-bsc/+/29364/comment/83ca420b_c246797a PS1, Line 453: LOGPFOH(DNM, LOGL_ERROR, foh, "IPACC RSL Connect ACK received on incorrect object class %d!\n", foh->obj_class);
(log string of object class? same below)
the obj class string should already be printed as part of LOGPFOH, so printing the string again is not that useful.
File src/osmo-bsc/nm_bb_transc_fsm.c:
https://gerrit.osmocom.org/c/osmo-bsc/+/29364/comment/50cfc49f_6b881dda PS1, Line 254: bb_transc->mo.opstart_sent = false;
(patch would look nicer without move of this line)
It still makes sense to move it since it follows better the natural sequence of events on how this flags are used/set.