Attention is currently required from: neels.

Patch set 1:Code-Review +2

View Change

2 comments:

• File src/osmo-bsc/bts_ipaccess_nanobts.c:

  • Patch Set #1, Line 453: LOGPFOH(DNM, LOGL_ERROR, foh, "IPACC RSL Connect ACK received on incorrect object class %d!\n", foh->obj_class);

    (log string of object class? same below)

    the obj class string should already be printed as part of LOGPFOH, so printing the string again is not that useful.

• File src/osmo-bsc/nm_bb_transc_fsm.c:

  • Patch Set #1, Line 254: bb_transc->mo.opstart_sent = false;

    (patch would look nicer without move of this line)

    It still makes sense to move it since it follows better the natural sequence of events on how this flags are used/set.

To view, visit change 29364. To unsubscribe, or for help writing mail filters, visit settings.