Attention is currently required from: laforge.
Jenkins Builder has posted comments on this change. (
https://gerrit.osmocom.org/c/libosmocore/+/30763?usp=email )
Change subject: core: Add software UART implementation
......................................................................
Patch Set 2:
(2 comments)
File src/core/soft_uart.c:
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-12426):
https://gerrit.osmocom.org/c/libosmocore/+/30763/comment/b0170fb0_f662a3f6
PS2, Line 160: for (size_t i = 0; i < n_ubits; i++) {
braces {} are not necessary for single statement blocks
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-12426):
https://gerrit.osmocom.org/c/libosmocore/+/30763/comment/f508a9e9_5c625910
PS2, Line 196: for (size_t i = 0; i < n_ubits; i++) {
braces {} are not necessary for single statement blocks
--
To view, visit
https://gerrit.osmocom.org/c/libosmocore/+/30763?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I2ca95963fd5852ddb89bdd35b86b31489127fe84
Gerrit-Change-Number: 30763
Gerrit-PatchSet: 2
Gerrit-Owner: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Comment-Date: Thu, 16 Nov 2023 09:06:18 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment