Change in osmocom-bb[master]: trxcon: make l1sched logging configurable, use trxcon->fi as prefix

Attention is currently required from: laforge, fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/28744 ) Change subject: trxcon: make l1sched logging configurable, use trxcon->fi as prefix ...................................................................... Patch Set 3: (1 comment) File src/host/trxcon/src/sched_trx.c: https://gerrit.osmocom.org/c/osmocom-bb/+/28744/comment/88f7aa43_2a2e35af PS3, Line 167: .cfg = *cfg, I don't see this struct l1sched_state knows anything about such a "trxcon_inst" you mention here, so you are simply adding some phantom requirement here regarding some unknown object to be alive the same timespan as this one. That's really bad design imho and makes it really confusing. You either: - pass ownership of the str pointer to this object (bad because you don't really know whether it was allocated by the caller using the heap or the stack). - Copy the log prefix into a new string owned by this object (good way imho). -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/28744 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I26da1a506b02502a3a6a887533c35fb09c13c429 Gerrit-Change-Number: 28744 Gerrit-PatchSet: 3 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Mon, 25 Jul 2022 15:15:40 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment