Attention is currently required from: laforge, fixeria.

View Change

1 comment:

• File src/host/trxcon/src/sched_trx.c:

  • Patch Set #3, Line 167: .cfg = *cfg,

    The lifetime of trxcon_inst is limited by the lifetime of l1sched_state, they cannot exist independe […]

    I don't see this struct l1sched_state knows anything about such a "trxcon_inst" you mention here, so you are simply adding some phantom requirement here regarding some unknown object to be alive the same timespan as this one. That's really bad design imho and makes it really confusing.

    You either:

    • pass ownership of the str pointer to this object (bad because you don't really know whether it was allocated by the caller using the heap or the stack).
    • Copy the log prefix into a new string owned by this object (good way imho).

To view, visit change 28744. To unsubscribe, or for help writing mail filters, visit settings.