[S] Change in osmo-bsc[2023q1]: bts_is_online(): make the BTS pointer const, return bool

fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/32556 ) Change subject: bts_is_online(): make the BTS pointer const, return bool ...................................................................... bts_is_online(): make the BTS pointer const, return bool Change-Id: Idb4f9f8862041c5902df0e6e8d1ac2a60ada95df (cherry picked from commit 856c6dc2f51d7d189cce462dfce7e308f1ff3ab2) --- M src/osmo-bsc/bts.c 1 file changed, 13 insertions(+), 3 deletions(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, approved diff --git a/src/osmo-bsc/bts.c b/src/osmo-bsc/bts.c index 9be2454..5718915 100644 --- a/src/osmo-bsc/bts.c +++ b/src/osmo-bsc/bts.c @@ -885,14 +885,14 @@ return (base->depends_on[idx] & (1U << bit)) > 0; } -static int bts_is_online(struct gsm_bts *bts) +static bool bts_is_online(const struct gsm_bts *bts) { /* TODO: support E1 BTS too */ if (!is_ipaccess_bts(bts)) - return 1; + return true; if (!bts->oml_link) - return 0; + return false; return bts->mo.nm_state.operational == NM_OPSTATE_ENABLED; } -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/32556 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: 2023q1 Gerrit-Change-Id: Idb4f9f8862041c5902df0e6e8d1ac2a60ada95df Gerrit-Change-Number: 32556 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria &lt;vyanitskiy(a)sysmocom.de&gt; Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria &lt;vyanitskiy(a)sysmocom.de&gt; Gerrit-Reviewer: pespin &lt;pespin(a)sysmocom.de&gt; Gerrit-MessageType: merged