Attention is currently required from: osmith.
pespin has posted comments on this change. (
https://gerrit.osmocom.org/c/libosmo-gprs/+/33981 )
Change subject: rlcmac: Use enum gprs_rlcmac_radio_priority internally everywhere
......................................................................
Patch Set 2:
(2 comments)
File src/rlcmac/gre.c:
https://gerrit.osmocom.org/c/libosmo-gprs/+/33981/comment/55624109_5cefb879
PS2, Line 226: ll_pdu_len, get_value_string(osmo_gprs_rlcmac_llc_sapi_names,
sapi), radio_prio + 1);
I wonder if it made sense to adjust the enum in
types_private.h: […]
No, that enum is encoding transmitted in the wire, cannot be
changed.
Furthermore, it's more confortable having them 0..3 since we are indexing arrays in
llc_queue based on that.
File tests/rlcmac/rlcmac_prim_test.c:
https://gerrit.osmocom.org/c/libosmo-gprs/+/33981/comment/396c4d1a_7c6b334a
PS2, Line 991: 2
2 instead of 1 on purpose?
Yes, in general SNDCP
has lower prio than GMM. It doesn't matter much here, but then we also test other
values here.
--
To view, visit
https://gerrit.osmocom.org/c/libosmo-gprs/+/33981
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: libosmo-gprs
Gerrit-Branch: master
Gerrit-Change-Id: If2d1946522bc4a1c19d65acb23605f1a3f05ab45
Gerrit-Change-Number: 33981
Gerrit-PatchSet: 2
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: osmith <osmith(a)sysmocom.de>
Gerrit-Comment-Date: Fri, 28 Jul 2023 11:40:36 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: osmith <osmith(a)sysmocom.de>
Gerrit-MessageType: comment