Attention is currently required from: osmith.

View Change

2 comments:

• File src/rlcmac/gre.c:

  • Patch Set #2, Line 226: ll_pdu_len, get_value_string(osmo_gprs_rlcmac_llc_sapi_names, sapi), radio_prio + 1);

    I wonder if it made sense to adjust the enum in types_private.h: […]

    No, that enum is encoding transmitted in the wire, cannot be changed.
    Furthermore, it's more confortable having them 0..3 since we are indexing arrays in llc_queue based on that.

• File tests/rlcmac/rlcmac_prim_test.c:

  • Patch Set #2, Line 991: 2

    2 instead of 1 on purpose?

    Yes, in general SNDCP has lower prio than GMM. It doesn't matter much here, but then we also test other values here.

To view, visit change 33981. To unsubscribe, or for help writing mail filters, visit settings.