[S] Change in osmocom-bb[master]: l1gprs: fix NULL pointer dereference in l1gprs_unregister_tbf()

Attention is currently required from: pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/31969 ) Change subject: l1gprs: fix NULL pointer dereference in l1gprs_unregister_tbf() ...................................................................... Patch Set 1: (1 comment) File src/shared/l1gprs.c: https://gerrit.osmocom.org/c/osmocom-bb/+/31969/comment/82ae0b89_a4b08368 PS1, Line 138: "%s(): " LOG_TBF_FMT " not found\n", Following this logic using macros in general makes the code complicated because "you're not sure what you pass matches with what you have in the macro until you look at it". So you want me to expand the `LOG_TBF_FMT` macro here. I disagree and prefer to keep it in the format string. If we ever change `LOG_TBF_FMT`, we're sure that this logging statement is also consistent with the new format (because we'll see compiler warnings). -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/31969 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: Ie3e7b5a8a205d4410de458dec2fde466493d31ce Gerrit-Change-Number: 31969 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 20 Mar 2023 09:26:41 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: comment