Attention is currently required from: pespin.

View Change

1 comment:

• File src/shared/l1gprs.c:

  • Patch Set #1, Line 138: "%s(): " LOG_TBF_FMT " not found\n",

    Yes but my point is that passing that LOG_TBF_FMT here makes the code more difficult to understand b […]

    Following this logic using macros in general makes the code complicated because "you're not sure what you pass matches with what you have in the macro until you look at it". So you want me to expand the `LOG_TBF_FMT` macro here. I disagree and prefer to keep it in the format string. If we ever change `LOG_TBF_FMT`, we're sure that this logging statement is also consistent with the new format (because we'll see compiler warnings).

To view, visit change 31969. To unsubscribe, or for help writing mail filters, visit settings.