Attention is currently required from: jolly.
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/35379?usp=email )
Change subject: OML: Add Get Attributes for supported MOs for Channel Object Class
......................................................................
Patch Set 1: Code-Review+1
(1 comment)
File src/common/oml.c:
https://gerrit.osmocom.org/c/osmo-bts/+/35379/comment/bd7dd2df_2ccbfafc
PS1, Line 480: if (mo->obj_class == NM_OC_RADIO_CARRIER || mo->obj_class == NM_OC_BASEB_TRANSC ||
maybe use a switch-statement here?
--
To view, visit
https://gerrit.osmocom.org/c/osmo-bts/+/35379?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: I56e067be9e5c17625c7da4e982b90927802f57b4
Gerrit-Change-Number: 35379
Gerrit-PatchSet: 1
Gerrit-Owner: jolly
andreas@eversberg.eu
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria
vyanitskiy@sysmocom.de
Gerrit-Reviewer: pespin
pespin@sysmocom.de
Gerrit-Attention: jolly
andreas@eversberg.eu
Gerrit-Comment-Date: Mon, 18 Dec 2023 16:37:59 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment