Attention is currently required from: laforge, pespin.
falconia has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-bts/+/32110 )
Change subject: common+trx: make uplink ECU optional
......................................................................
Patch Set 4:
(1 comment)
File src/common/vty.c:
https://gerrit.osmocom.org/c/osmo-bts/+/32110/comment/9d296871_a24c8ff9
PS4, Line 809: bts->suppress_ul_ecu = false;
I find it weird that you are kinda changing the
boolean logic with the VTY command when using the va […]
I wrote the code the way I
did so that the default of having this UL ECU enabled would happen on its own through
zero-init of struct gsm_bts. But I agree that an affirmative boolean such as use_ul_ecu
will be much better, and I just found the right place to set the backward-compatible
default in bts_init(). I will spin a new patchset.
--
To view, visit
https://gerrit.osmocom.org/c/osmo-bts/+/32110
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: I0acca9c6d7da966a623287563e0789db9e0fae8e
Gerrit-Change-Number: 32110
Gerrit-PatchSet: 4
Gerrit-Owner: falconia <falcon(a)freecalypso.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-CC: laforge <laforge(a)osmocom.org>
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Mon, 15 May 2023 17:18:53 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: comment