Attention is currently required from: laforge, pespin.
falconia has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/32110 )
Change subject: common+trx: make uplink ECU optional ......................................................................
Patch Set 4:
(1 comment)
File src/common/vty.c:
https://gerrit.osmocom.org/c/osmo-bts/+/32110/comment/9d296871_a24c8ff9 PS4, Line 809: bts->suppress_ul_ecu = false;
I find it weird that you are kinda changing the boolean logic with the VTY command when using the va […]
I wrote the code the way I did so that the default of having this UL ECU enabled would happen on its own through zero-init of struct gsm_bts. But I agree that an affirmative boolean such as use_ul_ecu will be much better, and I just found the right place to set the backward-compatible default in bts_init(). I will spin a new patchset.