Attention is currently required from: pespin.
fixeria has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37184?usp=email )
Change subject: s1gw: add S1AP Server (dispatcher) component
......................................................................
Patch Set 1:
(1 comment)
File s1gw/S1AP_Server.ttcn:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37184/comment/e8d4c66f_beab…
PS1, Line 1: module S1AP_Server {
There already exists `library/S1AP_Emulation.ttcn`, which is used by ttcn3-mme-test for
emulating eNB connection(s). That component implements the client (eNB) role. I would like
to avoid confusion by not re-using the same component name. Also, we have
`remsim/RSPRO_Server.ttcn`, so I think it's fine.
May be worth renaming it for people quickly
understanding what it is about.
IMO, the "server" explains more than just emulation, which can be client or
server.
--
To view, visit
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37184?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Ib8a14c1a76c980f4d8a153461c9b63d205574573
Gerrit-Change-Number: 37184
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Tue, 11 Jun 2024 13:32:08 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: comment