Attention is currently required from: fixeria.
pespin has posted comments on this change. (
https://gerrit.osmocom.org/c/libosmo-gprs/+/31751 )
Change subject: rlcmac: ul_tbf: Implement support for TBF Starting Time
......................................................................
Patch Set 1:
(2 comments)
File include/osmocom/gprs/rlcmac/rlcmac_dec.h:
https://gerrit.osmocom.org/c/libosmo-gprs/+/31751/comment/f7ac860f_38b6bda8
PS1, Line 8: #include <osmocom/gsm/gsm0502.h>
: #include <osmocom/gsm/gsm_utils.h>
Why are you including these headers? I guess because
some stuff is needed for the `sched. […]
ACK, I put them in the wrong file. Those
where meant for the .c, not the .h.
File src/rlcmac/rlcmac.c:
https://gerrit.osmocom.org/c/libosmo-gprs/+/31751/comment/f160c0c3_0f466b57
PS1, Line 194: uint32_t fn
Unused?
It is still unused here but will be used
in follow up patches anywhere. Since I'm propagating fn in the caller function
everywhere I thought it's a good idea to pass it here now too even if it's not yet
used here due to missing implementation.
--
To view, visit
https://gerrit.osmocom.org/c/libosmo-gprs/+/31751
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: libosmo-gprs
Gerrit-Branch: master
Gerrit-Change-Id: Id81f16743f2c464e01caf27ba2eb8c0fc715fe8a
Gerrit-Change-Number: 31751
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Thu, 09 Mar 2023 09:24:49 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-MessageType: comment