Attention is currently required from: fixeria.

View Change

2 comments:

• File include/osmocom/gprs/rlcmac/rlcmac_dec.h:

  • Patch Set #1, Line 8:

    #include <osmocom/gsm/gsm0502.h>
    #include <osmocom/gsm/gsm_utils.h>
    

    Why are you including these headers? I guess because some stuff is needed for the `sched. […]

    ACK, I put them in the wrong file. Those where meant for the .c, not the .h.

• File src/rlcmac/rlcmac.c:

  • Patch Set #1, Line 194: uint32_t fn

    Unused?

    It is still unused here but will be used in follow up patches anywhere. Since I'm propagating fn in the caller function everywhere I thought it's a good idea to pass it here now too even if it's not yet used here due to missing implementation.

To view, visit change 31751. To unsubscribe, or for help writing mail filters, visit settings.