pespin has submitted this change. (
https://gerrit.osmocom.org/c/osmocom-bb/+/30977 )
Change subject: layer23: Move script_lua_close() call outside of settings.c
......................................................................
layer23: Move script_lua_close() call outside of settings.c
The only caller of gsm_settings_exit() is in app_mobile so far, which is
the only app supporting/using lua scripting so far.
Change-Id: I634a4514ead9d064e7509c3fbbb3a2c89c7f3a56
---
M src/host/layer23/src/mobile/app_mobile.c
M src/host/layer23/src/mobile/settings.c
2 files changed, 1 insertion(+), 3 deletions(-)
Approvals:
Jenkins Builder: Verified
osmith: Looks good to me, approved
diff --git a/src/host/layer23/src/mobile/app_mobile.c
b/src/host/layer23/src/mobile/app_mobile.c
index b4466de..a161fc3 100644
--- a/src/host/layer23/src/mobile/app_mobile.c
+++ b/src/host/layer23/src/mobile/app_mobile.c
@@ -417,6 +417,7 @@
if (ms->deleting) {
gsm_settings_exit(ms);
+ script_lua_close(ms);
llist_del(&ms->entity);
talloc_free(ms);
work = 1;
diff --git a/src/host/layer23/src/mobile/settings.c
b/src/host/layer23/src/mobile/settings.c
index b6e251b..3d4d712 100644
--- a/src/host/layer23/src/mobile/settings.c
+++ b/src/host/layer23/src/mobile/settings.c
@@ -160,9 +160,6 @@
llist_del(&abbrev->list);
talloc_free(abbrev);
}
-
- script_lua_close(ms);
-
return 0;
}
--
To view, visit
https://gerrit.osmocom.org/c/osmocom-bb/+/30977
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-Change-Id: I634a4514ead9d064e7509c3fbbb3a2c89c7f3a56
Gerrit-Change-Number: 30977
Gerrit-PatchSet: 3
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: msuraev <msuraev(a)sysmocom.de>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-CC: neels <nhofmeyr(a)sysmocom.de>
Gerrit-MessageType: merged