Attention is currently required from: pespin.
fixeria has posted comments on this change. (
https://gerrit.osmocom.org/c/osmocom-bb/+/34139 )
Change subject: trxcon: properly handle PDCH slotmask in UL/DL TBF CFG.Req
......................................................................
Patch Set 2:
(1 comment)
File src/host/trxcon/src/trxcon_fsm.c:
https://gerrit.osmocom.org/c/osmocom-bb/+/34139/comment/d4c0f09b_2c7443cf
PS1, Line 577: handle_tbf_cfg_req(trxcon);
This patch is missing updating in the case where
l1gprs_handle_ul_tbf_cfg_req() delays call to l1gpr […]
Using trxcon specific API
from l1gprs is not an option. The reason is that it's also employed by virtphy and
[some day] will be employed by the firmware. We need an abstract API for that, something
like `l1gprs_pdch_state_cb()`. It can either be a callback stored in `struct
l1gprs_state`, or even better an external function to be defined by the l1gprs API user.
--
To view, visit
https://gerrit.osmocom.org/c/osmocom-bb/+/34139
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-Change-Id: I4c2ff25217fba0b6b4704f023071b86ed9afb55c
Gerrit-Change-Number: 34139
Gerrit-PatchSet: 2
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Thu, 10 Aug 2023 19:14:08 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: comment